-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad forward compatibility to rocksdb #2918
Comments
Why don't compile with the rocksdb in thrid-party? |
For testing purpose. Need to use new features not existing in the version which nebula is using. In addition, the previous code was not a good practice anyway. |
This force to handle each enumerate instead of return unknown directly. |
I am trying to follow the original logic, where it does return unknown if there is no match. In addition, other functions in the file are doing the same, like flushReasonString, backgroundErrorReasonString, etc. |
The master RocksDB has a new enum
CompactionReason: kChangeTemperature
. If we compile the current nebula code with master rocksdb, it has a warning of not handlingkChangeTemperature
, and warnings are treated as errors.The text was updated successfully, but these errors were encountered: