Concurrent create tag and edge with same name may be both succeed.

[cangfengzhs]

Please check the FAQ documentation before raising an issue

Please check the FAQ documentation and old issues before raising an issue in case someone has asked the same question that you are asking.

Describe the bug (required)

 // CreateTagProcessor.cpp
  {
    // if there is an edge of the same name
    // TODO: there exists race condition, we should address it in the future
    folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock());
    auto conflictRet = getEdgeType(spaceId, tagName);
    ......
  }  // <------------------------Unlock!!!!!!!!!
  auto columns = req.get_schema().get_columns();
  ......

Because edgeLock unlock before finish create tag, if there are two threads create tag/edge concurrency, may be both succeed.

Your Environments (required)

• OS: uname -a
• Compiler: g++ --version or clang++ --version
• CPU: lscpu
• Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

1. Step 1
2. Step 2
3. Step 3

Expected behavior

A clear and concise description of what you expected to happen.

Additional context

Provide logs and configs, or any other context to trace the problem.