Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GetProps and ScanVertices/ScanEdges RPC. #3450

Closed
Shylock-Hg opened this issue Dec 10, 2021 · 0 comments
Closed

Merge GetProps and ScanVertices/ScanEdges RPC. #3450

Shylock-Hg opened this issue Dec 10, 2021 · 0 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Dec 10, 2021

Introduction

Merge GetProps and ScanVertices/ScanEdges into one RPC. Because they should behaviors same except ScanVertices and ScanEdges get vertex/edge id by scan storage but GetProps get vertex/edge id from input.

  1. So there are much same code in their implementation, combine to one will reduce these.
  2. Combine to one will guarantee behavioring same more. And easier to maintain.

Contents

The combined RPC named GeProps, with given vertex/edge id it behaviors as origin GetProps, without it behaviors as ScanVertices and ScanEdges.

But maybe lead to more complex to plan analysis. Or we don't merge the related plan node/executor.

Related work

@Shylock-Hg Shylock-Hg added the type/enhancement Type: make the code neat or more efficient label Dec 10, 2021
@Shylock-Hg Shylock-Hg changed the title Merge GetProp and ScanVertices/ScanEdges RPC. Merge GetProps and ScanVertices/ScanEdges RPC. Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

2 participants