-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign scan vertices #3688
Comments
According to the current implementation, tags will be specified in Scan vertex, and only vertexes with these tags will be accessed. If it is traversed according to vertexKey, all points will be traversed. I'm not quite sure if this logic is appropriate. |
Yes, current implementation will ignore vertex without any tags. |
So do we have to change it to traverse all the vertices regardless of whether there is a corresponding tag? I'm not sure how much impact this change will have |
Yes, ScanVertices should return one row for each vertex regardless of whether there are any tags on it. |
I think we shouldn't do any redesign for 3.4. Sounds too big. @Shylock-Hg what do you think? |
It's a bug of vertex key, now it's removed. I close it. @cangfengzhs |
Please check the FAQ documentation before raising an issue
Describe the bug (required)
Before #3328 we scan vertices by scan tags, but now it's mistake. So we need to redesign scan vertices.
Your Environments (required)
uname -a
g++ --version
orclang++ --version
lscpu
a3ffc7d8
)How To Reproduce(required)
Steps to reproduce the behavior:
Expected behavior
Additional context
The text was updated successfully, but these errors were encountered: