Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign scan vertices #3688

Closed
Shylock-Hg opened this issue Jan 11, 2022 · 6 comments
Closed

Redesign scan vertices #3688

Shylock-Hg opened this issue Jan 11, 2022 · 6 comments
Assignees
Labels
affects/none PR/issue: this bug affects none version. need to discuss Solution: issue or PR without a clear conclusion on whether to handle it process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected type/enhancement Type: make the code neat or more efficient
Milestone

Comments

@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Jan 11, 2022

Please check the FAQ documentation before raising an issue

Describe the bug (required)

Before #3328 we scan vertices by scan tags, but now it's mistake. So we need to redesign scan vertices.

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

@cangfengzhs
Copy link
Contributor

According to the current implementation, tags will be specified in Scan vertex, and only vertexes with these tags will be accessed. If it is traversed according to vertexKey, all points will be traversed. I'm not quite sure if this logic is appropriate.

@Shylock-Hg
Copy link
Contributor Author

According to the current implementation, tags will be specified in Scan vertex, and only vertexes with these tags will be accessed. If it is traversed according to vertexKey, all points will be traversed. I'm not quite sure if this logic is appropriate.

Yes, current implementation will ignore vertex without any tags.

@cangfengzhs
Copy link
Contributor

cangfengzhs commented Mar 1, 2022

Yes, current implementation will ignore vertex without any tags.

So do we have to change it to traverse all the vertices regardless of whether there is a corresponding tag? I'm not sure how much impact this change will have

@Shylock-Hg
Copy link
Contributor Author

Yes, ScanVertices should return one row for each vertex regardless of whether there are any tags on it.

@cangfengzhs cangfengzhs mentioned this issue Mar 2, 2022
11 tasks
@Sophie-Xie Sophie-Xie modified the milestones: v3.1.0, v3.2.0 Mar 24, 2022
@Sophie-Xie Sophie-Xie assigned critical27 and unassigned cangfengzhs Mar 24, 2022
@Sophie-Xie Sophie-Xie added type/enhancement Type: make the code neat or more efficient type/bug Type: something is unexpected and removed type/bug Type: something is unexpected labels Apr 28, 2022
@Sophie-Xie Sophie-Xie removed this from the v3.2.0 milestone Apr 28, 2022
@Shylock-Hg Shylock-Hg added the type/bug Type: something is unexpected label Aug 24, 2022
@Sophie-Xie Sophie-Xie added the need to discuss Solution: issue or PR without a clear conclusion on whether to handle it label Dec 9, 2022
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Dec 9, 2022
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Dec 9, 2022
@xtcyclist
Copy link
Contributor

I think we shouldn't do any redesign for 3.4. Sounds too big. @Shylock-Hg what do you think?

@Shylock-Hg
Copy link
Contributor Author

Shylock-Hg commented Dec 16, 2022

I think we shouldn't do any redesign for 3.4. Sounds too big. @Shylock-Hg what do you think?

It's a bug of vertex key, now it's removed. I close it. @cangfengzhs

@github-actions github-actions bot added the process/fixed Process of bug label Dec 16, 2022
@HarrisChu HarrisChu added the process/done Process of bug label Jan 4, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. need to discuss Solution: issue or PR without a clear conclusion on whether to handle it process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

6 participants