Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The use of the symbol = in CREATE syntax #3949

Closed
cooper-lzy opened this issue Feb 28, 2022 · 1 comment
Closed

The use of the symbol = in CREATE syntax #3949

cooper-lzy opened this issue Feb 28, 2022 · 1 comment
Assignees
@CPWstatic
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.1.0

Comments

@cooper-lzy
Copy link
Contributor

  1. The comment inside attributes do not use the symbol =, and comments outside attributes use the symbol =.
  2. The comment outside attributes in the create tag and create index is inconsistent.
    image
@cooper-lzy cooper-lzy changed the title The use of the symbol = CREATE syntax The use of the symbol = in CREATE syntax Feb 28, 2022
@cooper-lzy cooper-lzy mentioned this issue Feb 28, 2022
Merged
@Sophie-Xie Sophie-Xie added the type/bug Type: something is unexpected label Feb 28, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Feb 28, 2022
@CPWstatic CPWstatic added type/enhancement Type: make the code neat or more efficient and removed type/bug Type: something is unexpected labels Feb 28, 2022
@CPWstatic
Copy link
Contributor

CPWstatic commented Feb 28, 2022 •
edited
Loading

The comment seems quite different inside/outside the attributes parentheses. I think they don't have to use the same syntax. Besides, we are referring to the syntax of SQL.
https://dev.mysql.com/doc/refman/8.0/en/create-table.html
https://dev.mysql.com/doc/refman/8.0/en/create-index.html

@jamieliu1023 jamieliu1023 mentioned this issue Mar 5, 2022
Closed
@jamieliu1023 jamieliu1023 mentioned this issue Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPWstatic CPWstatic

Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
3 participants
@CPWstatic @cooper-lzy @Sophie-Xie