Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold constant for set #4898

Closed
wenhaocs opened this issue Nov 17, 2022 · 2 comments · Fixed by #4901
Closed

Fold constant for set #4898

wenhaocs opened this issue Nov 17, 2022 · 2 comments · Fixed by #4901
Assignees
@czpmango
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wenhaocs
Copy link
Contributor

We may need to fold constant for set as the current eval of set takes too much cpu.
image
@wenhaocs wenhaocs added the type/enhancement Type: make the code neat or more efficient label Nov 17, 2022
@yixinglu
Copy link
Contributor

@czpmango After this expression optimization, we can give a InExpression to reduce the overhead of switch when calling eval.

@czpmango czpmango mentioned this issue Nov 17, 2022
Merged
11 tasks
@czpmango
Copy link
Contributor

@czpmango After this expression optimization, we can give a InExpression to reduce the overhead of switch when calling eval.

ACK.

@wey-gu wey-gu mentioned this issue Nov 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czpmango czpmango

Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fold constant for List/Set expression czpmango/nebula
3 participants
@yixinglu @wenhaocs @czpmango