Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages in MetaClient.cpp #4948

Closed
xtcyclist opened this issue Nov 29, 2022 · 0 comments
Closed

Improve error messages in MetaClient.cpp #4948

xtcyclist opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
affects/master PR/issue: this bug affects master version. process/done Process of bug severity/minor Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@xtcyclist
Copy link
Contributor

Please check the FAQ documentation before raising an issue

Describe the bug (required)

Error messages like the following is hard to understand. Need to revise them.

    case nebula::cpp2::ErrorCode::E_CONFLICT:
      return Status::Error("Conflict!");

Please check all error messages in the MetaClient.cpp.

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

@xtcyclist xtcyclist added the type/bug Type: something is unexpected label Nov 29, 2022
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Nov 29, 2022
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Nov 29, 2022
@HarrisChu HarrisChu added affects/master PR/issue: this bug affects master version. severity/minor Severity of bug labels Dec 1, 2022
@github-actions github-actions bot removed affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Dec 1, 2022
@github-actions github-actions bot added the process/fixed Process of bug label Dec 16, 2022
@Hester-Gu Hester-Gu added the process/done Process of bug label Jan 13, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/master PR/issue: this bug affects master version. process/done Process of bug severity/minor Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

5 participants