Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result is incorrect if use + match, property is missing #5263

Closed
nebula-bots opened this issue Jan 16, 2023 · 0 comments · Fixed by #5390
Closed

result is incorrect if use + match, property is missing #5263

nebula-bots opened this issue Jan 16, 2023 · 0 comments · Fixed by #5390
Assignees
Labels
affects/master PR/issue: this bug affects master version. auto-sync process/done Process of bug severity/major Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@nebula-bots
Copy link
Contributor

(root@nebula) [nba]> use nba
Execution succeeded (time spent 507/10835 us)

Mon, 16 Jan 2023 18:19:34 CST

(root@nebula) [nba]> match (p) - [e] -> (v) where id(p)=="Tony Parker" return v.player.age limit 10
+--------------+
| v.player.age |
+--------------+
| 25           |
| 33           |
| 41           |
| 42           |
| 33           |
| 41           |
| 42           |
| __NULL__     |
| __NULL__     |
+--------------+

but

(root@nebula) [(none)]> use nba;match (p) - [e] -> (v) where id(p)=="Tony Parker" return v.player.age limit 10
+--------------+
| v.player.age |
+--------------+
| __NULL__     |
| __NULL__     |
| __NULL__     |
| __NULL__     |
| __NULL__     |
| __NULL__     |
| __NULL__     |
| __NULL__     |
| __NULL__     |
+--------------+
Got 9 rows (time spent 1809/12104 us)

Mon, 16 Jan 2023 18:19:59 CST
Execution Plan (optimize time 148 us)

-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
| id | name                   | dependencies | profiling data                                     | operator info                          |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
| 12 | Project                | 11           | ver: 0, rows: 9, execTime: 11us, totalTime: 11us   | outputVar: {                           |
|    |                        |              |                                                    |   "colNames": [                        |
|    |                        |              |                                                    |     "v.player.age"                     |
|    |                        |              |                                                    |   ],                                   |
|    |                        |              |                                                    |   "type": "DATASET",                   |
|    |                        |              |                                                    |   "name": "__Limit_9"                  |
|    |                        |              |                                                    | }                                      |
|    |                        |              |                                                    | inputVar: __Limit_11                   |
|    |                        |              |                                                    | columns: [                             |
|    |                        |              |                                                    |   "$-.v.player.age"                    |
|    |                        |              |                                                    | ]                                      |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
| 11 | Limit                  | 6            | ver: 0, rows: 9, execTime: 3us, totalTime: 4us     | outputVar: {                           |
|    |                        |              |                                                    |   "colNames": [                        |
|    |                        |              |                                                    |     "p",                               |
|    |                        |              |                                                    |     "e",                               |
|    |                        |              |                                                    |     "v"                                |
|    |                        |              |                                                    |   ],                                   |
|    |                        |              |                                                    |   "type": "DATASET",                   |
|    |                        |              |                                                    |   "name": "__Limit_11"                 |
|    |                        |              |                                                    | }                                      |
|    |                        |              |                                                    | inputVar: __AppendVertices_6           |
|    |                        |              |                                                    | offset: 0                              |
|    |                        |              |                                                    | count: 10                              |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
|  6 | AppendVertices         | 5            | {                                                  | outputVar: {                           |
|    |                        |              | ver: 0, rows: 9, execTime: 120us, totalTime: 519us |   "colNames": [                        |
|    |                        |              | resp[0]: {                                         |     "p",                               |
|    |                        |              |   "exec": "187(us)",                               |     "e",                               |
|    |                        |              |   "host": "192.168.8.6:10082",                     |     "v"                                |
|    |                        |              |   "total": "390(us)"                               |   ],                                   |
|    |                        |              | }                                                  |   "type": "DATASET",                   |
|    |                        |              | total_rpc: 417(us)                                 |   "name": "__AppendVertices_6"         |
|    |                        |              | }                                                  | }                                      |
|    |                        |              |                                                    | inputVar: __Traverse_5                 |
|    |                        |              |                                                    | space: 3                               |
|    |                        |              |                                                    | dedup: true                            |
|    |                        |              |                                                    | limit: -1                              |
|    |                        |              |                                                    | filter:                                |
|    |                        |              |                                                    | orderBy: []                            |
|    |                        |              |                                                    | src: none_direct_dst($-.e)             |
|    |                        |              |                                                    | props: [                               |
|    |                        |              |                                                    |   {                                    |
|    |                        |              |                                                    |     "props": [                         |
|    |                        |              |                                                    |       "_tag"                           |
|    |                        |              |                                                    |     ],                                 |
|    |                        |              |                                                    |     "tagId": 4                         |
|    |                        |              |                                                    |   },                                   |
|    |                        |              |                                                    |   {                                    |
|    |                        |              |                                                    |     "props": [                         |
|    |                        |              |                                                    |       "_tag"                           |
|    |                        |              |                                                    |     ],                                 |
|    |                        |              |                                                    |     "tagId": 6                         |
|    |                        |              |                                                    |   },                                   |
|    |                        |              |                                                    |   {                                    |
|    |                        |              |                                                    |     "props": [                         |
|    |                        |              |                                                    |       "_tag"                           |
|    |                        |              |                                                    |     ],                                 |
|    |                        |              |                                                    |     "tagId": 5                         |
|    |                        |              |                                                    |   }                                    |
|    |                        |              |                                                    | ]                                      |
|    |                        |              |                                                    | exprs:                                 |
|    |                        |              |                                                    | vertex_filter:                         |
|    |                        |              |                                                    | if_track_previous_path: true           |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
|  5 | Traverse               | 3            | {                                                  | outputVar: {                           |
|    |                        |              | ver: 0, rows: 9, execTime: 58us, totalTime: 715us  |   "colNames": [                        |
|    |                        |              | step[1]: [                                         |     "p",                               |
|    |                        |              |   {                                                |     "e"                                |
|    |                        |              |     "exec": "338(us)",                             |   ],                                   |
|    |                        |              |     "host": "192.168.8.6:10082",                   |   "type": "DATASET",                   |
|    |                        |              |     "storage_detail": {                            |   "name": "__Traverse_5"               |
|    |                        |              |       "GetNeighborsNode": "91(us)",                | }                                      |
|    |                        |              |       "HashJoinNode": "78(us)",                    | inputVar: __Dedup_3                    |
|    |                        |              |       "RelNode": "92(us)",                         | space: 3                               |
|    |                        |              |       "SingleEdgeNode": "74(us)"                   | dedup: true                            |
|    |                        |              |     },                                             | limit: -1                              |
|    |                        |              |     "total": "613(us)",                            | filter:                                |
|    |                        |              |     "total_rpc_time": "650(us)",                   | orderBy: []                            |
|    |                        |              |     "vertices": 1                                  | src: $-._vid                           |
|    |                        |              |   }                                                | edgeTypes: []                          |
|    |                        |              | ]                                                  | edgeDirection: OUT_EDGE                |
|    |                        |              | }                                                  | vertexProps:                           |
|    |                        |              |                                                    | edgeProps: [                           |
|    |                        |              |                                                    |   {                                    |
|    |                        |              |                                                    |     "props": [                         |
|    |                        |              |                                                    |       "_dst",                          |
|    |                        |              |                                                    |       "_type",                         |
|    |                        |              |                                                    |       "_rank"                          |
|    |                        |              |                                                    |     ],                                 |
|    |                        |              |                                                    |     "type": 9                          |
|    |                        |              |                                                    |   },                                   |
|    |                        |              |                                                    |   {                                    |
|    |                        |              |                                                    |     "props": [                         |
|    |                        |              |                                                    |       "_dst",                          |
|    |                        |              |                                                    |       "_type",                         |
|    |                        |              |                                                    |       "_rank"                          |
|    |                        |              |                                                    |     ],                                 |
|    |                        |              |                                                    |     "type": 7                          |
|    |                        |              |                                                    |   },                                   |
|    |                        |              |                                                    |   {                                    |
|    |                        |              |                                                    |     "props": [                         |
|    |                        |              |                                                    |       "_dst",                          |
|    |                        |              |                                                    |       "_type",                         |
|    |                        |              |                                                    |       "_rank"                          |
|    |                        |              |                                                    |     ],                                 |
|    |                        |              |                                                    |     "type": 8                          |
|    |                        |              |                                                    |   }                                    |
|    |                        |              |                                                    | ]                                      |
|    |                        |              |                                                    | statProps:                             |
|    |                        |              |                                                    | exprs:                                 |
|    |                        |              |                                                    | random: false                          |
|    |                        |              |                                                    | steps: 1..1                            |
|    |                        |              |                                                    | vertex filter:                         |
|    |                        |              |                                                    | edge filter:                           |
|    |                        |              |                                                    | if_track_previous_path: false          |
|    |                        |              |                                                    | first step filter:                     |
|    |                        |              |                                                    | tag filter:                            |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
|  3 | Dedup                  | 2            | ver: 0, rows: 1, execTime: 3us, totalTime: 3us     | outputVar: {                           |
|    |                        |              |                                                    |   "colNames": [                        |
|    |                        |              |                                                    |     "_vid"                             |
|    |                        |              |                                                    |   ],                                   |
|    |                        |              |                                                    |   "type": "DATASET",                   |
|    |                        |              |                                                    |   "name": "__Dedup_3"                  |
|    |                        |              |                                                    | }                                      |
|    |                        |              |                                                    | inputVar: __VAR_0                      |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
|  2 | PassThrough            | 1            | ver: 0, rows: 0, execTime: 3us, totalTime: 4us     | outputVar: {                           |
|    |                        |              |                                                    |   "colNames": [                        |
|    |                        |              |                                                    |     "_vid"                             |
|    |                        |              |                                                    |   ],                                   |
|    |                        |              |                                                    |   "type": "DATASET",                   |
|    |                        |              |                                                    |   "name": "__VAR_0"                    |
|    |                        |              |                                                    | }                                      |
|    |                        |              |                                                    | inputVar:                              |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
|  1 | RegisterSpaceToSession | 0            | ver: 0, rows: 0, execTime: 20us, totalTime: 379us  | outputVar: {                           |
|    |                        |              |                                                    |   "colNames": [],                      |
|    |                        |              |                                                    |   "type": "DATASET",                   |
|    |                        |              |                                                    |   "name": "__RegisterSpaceToSession_1" |
|    |                        |              |                                                    | }                                      |
|    |                        |              |                                                    | inputVar:                              |
|    |                        |              |                                                    | space: nba                             |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------
|  0 | Start                  |              | ver: 0, rows: 0, execTime: 0us, totalTime: 10us    | outputVar: {                           |
|    |                        |              |                                                    |   "colNames": [],                      |
|    |                        |              |                                                    |   "type": "DATASET",                   |
|    |                        |              |                                                    |   "name": "__Start_0"                  |
|    |                        |              |                                                    | }                                      |
-----+------------------------+--------------+----------------------------------------------------+-----------------------------------------

Mon, 16 Jan 2023 18:20:12 CST

seems incorrect properties in AppendVertices

@nebula-bots nebula-bots added affects/none PR/issue: this bug affects none version. auto-sync severity/none Severity of bug type/bug Type: something is unexpected affects/master PR/issue: this bug affects master version. severity/major Severity of bug and removed severity/none Severity of bug affects/none PR/issue: this bug affects none version. labels Jan 16, 2023
@Sophie-Xie Sophie-Xie added this to the v3.5.0 milestone Feb 27, 2023
@github-actions github-actions bot added the process/fixed Process of bug label Mar 10, 2023
@nebula-bots nebula-bots added process/done Process of bug and removed process/fixed Process of bug labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/master PR/issue: this bug affects master version. auto-sync process/done Process of bug severity/major Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants