Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support multiple outputs in FunctionEvaluator #19901

Open
jobergum opened this issue Nov 8, 2021 · 3 comments
Open

Add support multiple outputs in FunctionEvaluator #19901

jobergum opened this issue Nov 8, 2021 · 3 comments
Assignees
Milestone

Comments

@jobergum
Copy link
Member

jobergum commented Nov 8, 2021

A model might have several outputs.

Current API only supports one output per FunctionEvaluator.

FunctionEvaluator evaluator  = modelsEvaluator.evaluatorOf("reader", "output_0");
FunctionEvaluator evaluator1  = modelsEvaluator.evaluatorOf("reader", "output_1");
FunctionEvaluator evaluator2  = modelsEvaluator.evaluatorOf("reader", "output_2");

Not supporting several outputs in one evaluator is not optimal for models with multiple outputs as you need to invoke the model several times, once for each result. Something like

FunctionEvaluator evaluator  = modelsEvaluator.evaluatorOf("reader", "output_0","output_1", "output_2");
@jobergum
Copy link
Member Author

Is this now complete with Vespa 8 @lesters ? If so, we should implement the reader using stateless evaluation for the dpr sample app.

@lesters
Copy link
Member

lesters commented Sep 28, 2022

@jobergum Some work still remains. I'll get back to this ASAP.

@baldersheim
Copy link
Contributor

soon timed out

@baldersheim baldersheim removed this from the soon milestone Sep 13, 2023
@kkraune kkraune added this to the soon milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants