Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose number of threads per search in metrics #31935

Open
dainiusjocas opened this issue Jul 10, 2024 · 0 comments
Open

Expose number of threads per search in metrics #31935

dainiusjocas opened this issue Jul 10, 2024 · 0 comments
Milestone

Comments

@dainiusjocas
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We are woking on query performance and estimating how much throughput can be handled per content node. We've made a nice Grafana dashboard with these estimates (based on docs and the Little's Law) but for now it is needed to manually add constants for how many threads are used per search per rank profile to make the numbers match.

The main pain point is that some queries require many threads (e.g. 4 or 8) while some are good with 1 or 2. And thread per search varies per rank-profile. We have about ~15 rank profiles.

The threads per search count per rank profile is mostly static in production except when full scale experiments are being run.

Having the default thread count as set in services.xml or in rank profile would also be useful.

Describe the solution you'd like
I'd like that Prometheus metrics for rank_profile type, e.g. content.proton.documentdb.matching.rank_profile.query_latency would contain a label for how many threads were actually used.

Describe alternatives you've considered
I've created promql with hardcoded thread counts per rank profile as multipliers in the price calculations.

Additional context
Vespa Slack thread.

@kkraune kkraune added this to the later milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants