fix: Check that resources are in kubeadm-config configmap before usin… #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g them In some conditions the k8s_info module can succeed but return and empty list of resources. This can happen when the api server is running but the kubeadm-config cm is missing, then the next tasks fail with undefined variables. This patch extends the condition on the kubernetes version check to ensure that resources from kubeadm-config are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g them
In some conditions the k8s_info module can succeed but return an empty list of resources. This can happen when the api server is running but the kubeadm-config cm is missing, then the next tasks fail with undefined variables.
This patch extends the condition on the kubernetes version check to ensure that resources from kubeadm-config are present.