-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize #85
Synchronize #85
Conversation
c6167a6
to
b376320
Compare
Moving this to draft, but currently unable to reproduce the check failures seen in github locally |
80b8623
to
b9f8ea4
Compare
@mnaser is there anything else I need to do on this PR? We don't have SSH running in OSA containers so synchronize is pretty hard to use. |
@okozachenko1203 could you please take a look also - this should be low risk as the regular code path with the synchronize module is not changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small review
Synchronize module does not work when for some reason there is no ssh to the target, which can happen when using custom ansible connection plugins to containerised targets. This patch adds the multi_copy action plugin which is a wrapper around the unarchive module, copying many files in one task.
This works on targets that do not have ssh enabled, which synchronize does not.
This patch also extends the molecule test to cover the case where a new version of a chart is uploaded which should result in a file being removed from the destination.
synchronize is based on rsync, which in turn requires ssh to the target. Things using a custom connection plugin (docker / lxc / lxd....) don't necessarily provide ssh to the target and synchronize fails.