Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize #85

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Synchronize #85

merged 3 commits into from
Apr 20, 2024

Conversation

jrosser
Copy link
Contributor

@jrosser jrosser commented Dec 4, 2023

synchronize is based on rsync, which in turn requires ssh to the target. Things using a custom connection plugin (docker / lxc / lxd....) don't necessarily provide ssh to the target and synchronize fails.

@jrosser jrosser force-pushed the synchronize branch 3 times, most recently from c6167a6 to b376320 Compare December 4, 2023 12:56
@jrosser jrosser marked this pull request as draft December 4, 2023 14:20
@jrosser
Copy link
Contributor Author

jrosser commented Dec 4, 2023

Moving this to draft, but currently unable to reproduce the check failures seen in github locally

@jrosser jrosser force-pushed the synchronize branch 4 times, most recently from 80b8623 to b9f8ea4 Compare December 6, 2023 17:54
@jrosser jrosser marked this pull request as ready for review January 9, 2024 09:38
@jrosser
Copy link
Contributor Author

jrosser commented Mar 12, 2024

@mnaser is there anything else I need to do on this PR? We don't have SSH running in OSA containers so synchronize is pretty hard to use.

@jrosser
Copy link
Contributor Author

jrosser commented Mar 14, 2024

@okozachenko1203 could you please take a look also - this should be low risk as the regular code path with the synchronize module is not changed

Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small review

roles/upload_helm_chart/tasks/main.yml Outdated Show resolved Hide resolved
Jonathan Rosser added 3 commits April 2, 2024 10:35
Synchronize module does not work when for some reason there is no
ssh to the target, which can happen when using custom ansible
connection plugins to containerised targets.

This patch adds the multi_copy action plugin which is a wrapper
around the unarchive module, copying many files in one task.
This works on targets that do not have ssh enabled, which synchronize
does not.
This patch also extends the molecule test to cover the case
where a new version of a chart is uploaded which should result
in a file being removed from the destination.
@mnaser mnaser merged commit 9fac93a into vexxhost:main Apr 20, 2024
104 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants