Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix ovn db mount path #1044

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: fix ovn db mount path #1044

merged 1 commit into from
Apr 2, 2024

Conversation

okozachenko1203
Copy link
Member

@okozachenko1203 okozachenko1203 commented Apr 1, 2024 •
edited by mnaser
Loading

@okozachenko1203 okozachenko1203 requested a review from mnaser April 1, 2024 10:05
@mnaser
Copy link
Member

mnaser commented Apr 1, 2024

recheck

@mnaser
Copy link
Member

mnaser commented Apr 2, 2024

@okozachenko1203 seems like this passes the normal OVN test (but then the existing setup always did).

Did you get a chance to confirm if this does fix it?

mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
fddc635 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
@mnaser mnaser mentioned this pull request Apr 2, 2024
Merged
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
e632253 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
3b5ffd3 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
a2119e7 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
0126005 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
5915364 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
0ea123e 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
af3c814 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
dcfe2b0 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
a1fea91 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
65f7d00 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
2afe778 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
a55a3fe 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
67c136e 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
7fee84b 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser added a commit that referenced this pull request Apr 2, 2024
@mnaser
ci(ovn): add verification tests for database
51ee9cf 
We realized that we actually were pointing to the wrong
folder for our database.  This adds tests to make sure
that we verify that the database is at the right place.

Depends-On: #1044

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
@okozachenko1203
Copy link
Member Author

@okozachenko1203 seems like this passes the normal OVN test (but then the existing setup always did).

Did you get a chance to confirm if this does fix it?

yes, it works as expected

@mnaser mnaser merged commit e192c9e into main Apr 2, 2024
15 of 18 checks passed
@mnaser mnaser deleted the fix-ovn-db-path branch April 2, 2024 16:54
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OVN NB and SB pods are not using the PVC for their databases
2 participants
@okozachenko1203 @mnaser