Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add CA mounts in the Prometheus oauth2 container #1329

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: add CA mounts in the Prometheus oauth2 container #1329

merged 1 commit into from
Jun 11, 2024

Conversation

mpiscaer
Copy link
Contributor

@mpiscaer mpiscaer commented Jun 7, 2024 •
edited
Loading

This issue fixes #1187

@mpiscaer mpiscaer force-pushed the fix/addCaMountPrometheus branch from 182a9a6 to ccff534 Compare June 8, 2024 10:27
@mpiscaer mpiscaer marked this pull request as ready for review June 8, 2024 12:14
@mpiscaer mpiscaer force-pushed the fix/addCaMountPrometheus branch from ccff534 to 63fba75 Compare June 8, 2024 12:15
@gtirloni
Copy link
Contributor

LGTM but if the cert is created by the ClusterIssuer, you can mount the CA cert from the cluster_issuer_self_signed_secret_name secret as well and avoid having to deal with host paths.

@gtirloni gtirloni requested a review from mnaser June 10, 2024 12:49
@mnaser mnaser added the gate label Jun 11, 2024
@mnaser
Copy link
Member

mnaser commented Jun 11, 2024

/cherry-pick stable/2023.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Jun 11, 2024

/cherry-pick stable/zed

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/zed in a new PR and assign it to you.

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atmosphere-ci atmosphere-ci bot merged commit f0836c2 into vexxhost:main Jun 11, 2024
4 checks passed
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1334

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot vexxhost-bot mentioned this pull request Jun 11, 2024
Merged
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1335

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot vexxhost-bot mentioned this pull request Jun 11, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Open
atmosphere-ci bot pushed a commit that referenced this pull request Jun 12, 2024
@vexxhost-bot
[stable/zed] fix: add CA mounts in the Prometheus oauth2 container (#…
18adb06 
…1335)

This is an automated cherry-pick of #1329
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Jun 17, 2024
@vexxhost-bot
[stable/2023.1] fix: add CA mounts in the Prometheus oauth2 container (…
3dabb2d 
…#1334)

This is an automated cherry-pick of #1329
/assign mnaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

Assignees
No one assigned
Labels
gate
Projects
None yet
Milestone
No milestone
4 participants
@mpiscaer @gtirloni @mnaser @vexxhost-bot