Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ClusterClass version #16

Closed
mnaser opened this issue Nov 7, 2022 · 2 comments · Fixed by #25 or #338
Closed

Dynamic ClusterClass version #16

mnaser opened this issue Nov 7, 2022 · 2 comments · Fixed by #25 or #338
Assignees
Labels
priority: critical Critical priority issues

Comments

@mnaser
Copy link
Member

mnaser commented Nov 7, 2022

The ClusterClass has as static name, we should probably use something like pbr to generate a dynamic name for the ClusterClass.

@mnaser mnaser added the priority: critical Critical priority issues label Nov 7, 2022
@mnaser
Copy link
Member Author

mnaser commented Nov 7, 2022

@okozachenko1203 you can use this:

https://stackoverflow.com/a/58512044

@mnaser
Copy link
Member Author

mnaser commented Nov 7, 2022

but I think this is better:

https://stackoverflow.com/a/52740408

because it will give us pbr versions which means if someone checks out a dev version we'll know which one it is

@mnaser mnaser closed this as completed in d7fbbf0 Nov 10, 2022
This was referenced Jul 31, 2023
This was referenced Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment