Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HalClient needs to ensure that IHttpConnections (and their HttpClients) are disposed eventually #12

Open
akilb opened this issue Nov 27, 2015 · 0 comments
Open

HalClient needs to ensure that IHttpConnections (and their HttpClients) are disposed eventually #12

akilb opened this issue Nov 27, 2015 · 0 comments

Comments

@akilb
Copy link

akilb commented Nov 27, 2015

We need to make sure that the HttpClients used by HalClient get disposed eventually to make sure that all handlers get disposed correctly.

e.g. CacheCow Client's CachingHandler depends on the HttpClient instance being disposed to prevent a memory leak (see aliostad/CacheCow#47)
@akilb akilb changed the title HalClient needs to dispose IHttpConnections (and HttpClient) when it is destroyed HalClient needs to ensure that IHttpConnections (and their HttpClients) are disposed eventually Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akilb