Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore should not ignore keymap's info.json #646

Closed
Jari27 opened this issue Jan 9, 2024 · 4 comments
Closed

.gitignore should not ignore keymap's info.json #646

Jari27 opened this issue Jan 9, 2024 · 4 comments

Comments

@Jari27
Copy link

Jari27 commented Jan 9, 2024

The info.json file in QMK can be used to provide a data-driven definition of keyboard.c and rules.mk. Is there any reason this commit added it to .gitignore?

Does vial not support info.json (completely)?

Otherwise, I think it's valuable to allow users to define (most of) their keymaps using info.json instead of keymap.c and rules.mk.

@Jari27
Copy link
Author

Jari27 commented Jan 9, 2024

Tagging the author: @zvecr

@lesshonor
Copy link
Contributor

lesshonor commented Jan 9, 2024

qmk/qmk_firmware#20408

Please don't tag QMK maintainers in the Vial repo.

@zvecr
Copy link
Contributor

zvecr commented Jan 10, 2024

.gitignore should not ignore keymap's info.json

This is conceptually incorrect.

info.json has never been supported at the keymap level. Updating the .gitignore attempts to improve PR quallity by both preventing users from committing the file in the first place, and flagging the addition in CI.

Otherwise, I think it's valuable to allow users to define (most of) their keymaps using info.json instead of keymap.c and rules.mk.

keymap.json is the data-driven equivalent of keymap.c. The current issue is that the 2 files are mutually exclusive.

In the future there is a plan to provide a more cohesive way to support mixed data-driven and traditional config.

Does vial not support info.json (completely)?

Not the qmk/qmk_firmware repo so i’m afraid I can’t assist with that question 🤷.

@Jari27
Copy link
Author

Jari27 commented Jan 10, 2024

qmk/qmk_firmware#20408

Please don't tag QMK maintainers in the Vial repo.

My bad, didn't realize the original commit came from QMK.

@Jari27 Jari27 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants