-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.gitignore should not ignore keymap's info.json #646
Comments
Tagging the author: @zvecr |
Please don't tag QMK maintainers in the Vial repo. |
This is conceptually incorrect.
In the future there is a plan to provide a more cohesive way to support mixed data-driven and traditional config.
Not the |
My bad, didn't realize the original commit came from QMK. |
The
info.json
file in QMK can be used to provide a data-driven definition ofkeyboard.c
andrules.mk
. Is there any reason this commit added it to.gitignore
?Does vial not support
info.json
(completely)?Otherwise, I think it's valuable to allow users to define (most of) their keymaps using
info.json
instead ofkeymap.c
andrules.mk
.The text was updated successfully, but these errors were encountered: