Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add check in viash ns ... to check namespace/component_name uniqueness #684

Closed
2 tasks done
Grifs opened this issue Apr 19, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Grifs
Copy link
Collaborator

Grifs commented Apr 19, 2024

Feature summary

Verify that all picked up components have an unique namespace & component_name combination.

Feature description

It is currently possible to define 2 or more files with the same namespace & component names.
src/ns1/comp.vsh.yml and src/ns2/comp.vsh.yml
both containing:

functionality:
  name: comp
  namespace: ns

Why is this feature beneficial?

Prevents collisions down the road.

Alternatives considered

No response

Possible solution

No response

Confirmation

  • I have searched the existing issues to make sure this is not a duplicate request.
  • I have provided clear and concise information about the feature.
@Grifs Grifs added the enhancement New feature or request label Apr 19, 2024
@Grifs Grifs self-assigned this Apr 19, 2024
@Grifs Grifs added this to the Viash 0.8.x milestone Apr 19, 2024
@Grifs
Copy link
Collaborator Author

Grifs commented Apr 24, 2024

Implemented in Viash 0.8.6

@Grifs Grifs closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant