Skip to content

Commit 26af3fd

Browse files
kouvibhatha
authored andcommitted
apacheGH-41169: [CI][Release] Specify --build-config explicitly on Windows (apache#41178)
### Rationale for this change apache#37821 changed to use `add_test()` usage from old style to new style: apache@1a1d2c8?diff=unified&w=1#diff-1ce47eec54afaee769086e1a720c5ed65bc347cd8fc60a233de67fd895dda329L763-R764 MSVC generators multi-config generators. With old style, all tests are run without specifying `--build-config` explicitly. With new style, we need to specify `--build-config` explicitly. See also: https://cmake.org/cmake/help/latest/command/add_test.html ### What changes are included in this PR? Specify `--build-config` explicitly. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#41169 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent 7c01f72 commit 26af3fd

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

dev/release/verify-release-candidate.bat

+4-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,10 @@ cmake --build . --target INSTALL --config Release || exit /B 1
122122
@rem Needed so python-test.exe works
123123
set PYTHONPATH_ORIGINAL=%PYTHONPATH%
124124
set PYTHONPATH=%CONDA_PREFIX%\Lib;%CONDA_PREFIX%\Lib\site-packages;%CONDA_PREFIX%\DLLs;%CONDA_PREFIX%;%PYTHONPATH%
125-
ctest -j%NUMBER_OF_PROCESSORS% --output-on-failure || exit /B 1
125+
ctest ^
126+
--build-config Release ^
127+
--output-on-failure ^
128+
--parallel %NUMBER_OF_PROCESSORS% || exit /B 1
126129
set PYTHONPATH=%PYTHONPATH_ORIGINAL%
127130
popd
128131

0 commit comments

Comments
 (0)