Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Update naming/docs based on feedback from internal beta #71

Closed
StannisZhou opened this issue Sep 17, 2021 · 0 comments · Fixed by #88
Closed

Update naming/docs based on feedback from internal beta #71

StannisZhou opened this issue Sep 17, 2021 · 0 comments · Fixed by #88
Milestone

Comments

@StannisZhou
Copy link
Contributor

StannisZhou commented Sep 17, 2021

From @lawchekun :

  • key_tuple in GenericVariableGroup -> variable_names
  • In general maybe move away from using keys and instead use names
  • Would probably be helpful if there's a short example showing that init_msgs can be used to setup/trigger the belief_propagation too in run_bp
@StannisZhou StannisZhou changed the title Update naming based on feedback from internal beta Update naming/docs based on feedback from internal beta Sep 22, 2021
@StannisZhou StannisZhou added this to the 0.2.1 milestone Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant