Skip compile & packaging if --no-build is set (serverless-heaven#560)

* Add copyExistingArtifacts to packageModules * Refactor packageModules * Set service path * Generate artifact name from service * Output artifacts to .webpack before copying * Set artifact name for service packaging * Skip webpack:compile if --no-build is set * Add webpack:package:copyExistingArtifacts hook * Make packageModules & packExternalModules no-op if skipCompile is set * Refactor packageModules * Remove artifact location setting from packageModules * Update cleanup to check this.keepOutputDirectory * Fix path join on Windows Co-authored-by: Miguel A. Calles MBA <44813512+miguel-a-calles-mba@users.noreply.github.com>
vicary · Mar 1, 2021 · 33e3a97 · 33e3a97
1 parent 4d8ff23
commit 33e3a97
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/lib/cleanup.js b/lib/cleanup.js
@@ -10,6 +10,7 @@ module.exports = {
     const keepOutputDirectory = this.keepOutputDirectory;
     const cli = this.options.verbose ? this.serverless.cli : { log: _.noop };
 
+    const keepOutputDirectory = this.keepOutputDirectory;
     if (!keepOutputDirectory) {
       cli.log(`Remove ${webpackOutputPath}`);
       if (this.serverless.utils.dirExistsSync(webpackOutputPath)) {

diff --git a/tests/cleanup.test.js b/tests/cleanup.test.js
@@ -55,9 +55,7 @@ describe('cleanup', () => {
     module = _.assign(
       {
         serverless,
-        options: {
-          verbose: true
-        },
+        options: {},
         webpackOutputPath: 'my/Output/Path'
       },
       baseModule

diff --git a/tests/packageModules.test.js b/tests/packageModules.test.js
@@ -74,8 +74,7 @@ describe('packageModules', () => {
       {
         serverless,
         options: {},
-        webpackOutputPath: '.webpack',
-        configuration: new Configuration()
+        webpackOutputPath: '.webpack'
       },
       baseModule
     );