Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert CountBy return type to KeyValuePair<,> #490

Closed
viceroypenguin opened this issue Aug 15, 2023 · 2 comments · Fixed by #498
Closed

Revert CountBy return type to KeyValuePair<,> #490

viceroypenguin opened this issue Aug 15, 2023 · 2 comments · Fixed by #498
Assignees
@a-reny
Labels
good first issue Good for newcomers
Milestone
6.0.0

Comments

@viceroypenguin
Copy link
Owner

viceroypenguin commented Aug 15, 2023 •
edited
Loading

Per dotnet/runtime#77716 (comment), the approved API for CountBy returns IEnumerable<KeyValuePair<int, TSource>> instead of IEnumerable<(int, TSource)>. SuperLinq should revert the return type to match the corelib approved API to encourage code-compatibility between SuperLinq and corelib.
@viceroypenguin viceroypenguin added this to the 6.0.0 milestone Aug 15, 2023
@viceroypenguin viceroypenguin added the good first issue Good for newcomers label Aug 15, 2023
@a-reny
Copy link

a-reny commented Aug 16, 2023

Can I take a go at this?

@viceroypenguin
Copy link
Owner Author

Sure! Feel free to ask if you have any questions.

@tcortega tcortega mentioned this issue Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-reny a-reny

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Revert CountBy return type to KeyValuePair<,> tcortega/SuperLinq
2 participants
@viceroypenguin @a-reny