Implement Email Notifications #61
Conversation
Parlance.Notifications/Channels/TranslationFreeze/TranslationFreezeNotificationChannel.cs
Outdated
Show resolved
Hide resolved
| // Get static properties using Reflection | ||
| var autoSubscriptionEventNameProperty = autoSubscriptionType.GetProperty("AutoSubscriptionEventName", BindingFlags.Public | BindingFlags.Static); | ||
| var channelNameProperty = channelType.GetProperty("ChannelName", BindingFlags.Public | BindingFlags.Static); | ||
|
|
||
| // Check if the properties exist | ||
| if (autoSubscriptionEventNameProperty == null || channelNameProperty == null) | ||
| { | ||
| throw new ArgumentException("The required static properties do not exist in the provided types."); | ||
| } | ||
|
|
||
| // Get the values of the static properties | ||
| var autoSubscriptionEventName = (string)autoSubscriptionEventNameProperty.GetValue(null!)!; | ||
| var channelName = (string)channelNameProperty.GetValue(null!)!; | ||
|
|
||
| // Call the original function | ||
| return await GetAutoSubscriptionPreference(channelName, autoSubscriptionEventName, userId); |
There was a problem hiding this comment.
This should call the generic overload using MakeGenericMethod
There was a problem hiding this comment.
This (and the other files like it) really feel like they want to be scoped services that are automatically resolved and invoked by some "main" hosted service that pulls from the message bus... we might want to see if MessagePipe has some integration with MS.Ext.DI, or maybe switch to a library that does
There was a problem hiding this comment.
This could be rewritten to use symbols instead of syntax
Parlance.Roslyn/SourceGenerators/Notifications/AutoSubscriptionAttributeSourceGenerator.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This source generator (and the other ones) should ideally be using IIncrementalGenerator instead of ISourceGenerator. The legacy model is deprecated and can cause performance problems in the IDE
This PR implements a framework for email notifications.
Closes #11
Closes #12
Closes #14