Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use only own quotes #151

Closed
meceo opened this issue Nov 5, 2022 · 7 comments
Closed

Possibility to use only own quotes #151

meceo opened this issue Nov 5, 2022 · 7 comments

Comments

@meceo
Copy link

meceo commented Nov 5, 2022

Is your feature request related to a problem? Please describe.
"I'm always frustrated when I have to read quotes from Justin Bieber that someone added" :) I think everyone is different and many people would like only to read quotes they find valuable.

Describe the solution you'd like
I could imagine the possibility of having a text area for quotes in settings where each quote is added in a separate line. Each line has a separator to determine the quote content and author.

Describe alternatives you've considered
Perhaps a list where an item is a quote that has 2 fields: content and author. The list should be unlimited in size. Items can be edited, added, and removed. Kind of a to-do list, but with 2 fields instead of 1.

@victrme
Copy link
Owner

victrme commented Nov 5, 2022

Hi @meceo :) That is a good idea !

The to-do list style would be friendlier, but that would be a lot of work just for this feature. I'm thinking a single text field to paste a list like this 👇 would be enough ?

[
    ["author", "quote"],
    ["author", "quote"],
]

@meceo
Copy link
Author

meceo commented Feb 12, 2023

@victrme is there anything I can do to push this further? I really miss the feature and I am willing to help.

@victrme
Copy link
Owner

victrme commented Feb 12, 2023

The feature itself is already done, but it is now tied to the biggest update we've done so far. I didn't think we would take that long to implement the other features, that's on me...

At this pace, it should be ready by the end of the month.

@meceo
Copy link
Author

meceo commented Mar 3, 2023

thank you @victrme. It's not part of https://github.com/victrme/Bonjourr/releases/tag/v1.15.6, correct? At least I don't see that in the changelog or the update.

@victrme
Copy link
Owner

victrme commented Mar 5, 2023

This feature is in 1.16.0, 1.15.6 was mostly bug fixes.

We're getting close @meceo ! 1.16.0 is ready, we basically only have to update the documentation now. I definitely should have added this feature in the december release though, my bad 😓

@victrme
Copy link
Owner

victrme commented Mar 15, 2023

Hello @meceo ! 1.16 is finally here !!

@meceo
Copy link
Author

meceo commented Mar 15, 2023

congratulations and thanks again.

@meceo meceo closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants