Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted quick links reappearing after refresh #152

Closed
markojurkovic opened this issue Nov 16, 2022 · 8 comments
Closed

Deleted quick links reappearing after refresh #152

markojurkovic opened this issue Nov 16, 2022 · 8 comments
Labels

Comments

@markojurkovic
Copy link

Hi there, first of all thank you for this wonderful extension.

I've noticed one thing regarding the quick links widget: if I delete a quick link, after reloading the Bonjourr start page, it reappears. I've tried also right clicking another quick link and selecting "Apply changes" after deleting another link, but it doesn't make a difference.

@markojurkovic markojurkovic changed the title Deleted quick links reappearing Deleted quick links reappearing after refresh Nov 16, 2022
@victrme victrme added the Bug label Nov 17, 2022
@victrme
Copy link
Owner

victrme commented Nov 17, 2022

Hello @markojurkovic :)

You are not the only one with this problem ! Unfortunately I can't seem to reproduce the issue on my on..

Can you paste your settings here ? I think it might have to do with the remove function crashing because of corrupted links

@markojurkovic
Copy link
Author

markojurkovic commented Nov 17, 2022

Sure, here are my current settings:

{
"cssHeight": 209,
"linksincpnn": {
"order": 3,
"_id": "linksincpnn",
"title": "Maps",
"icon": "https://www.google.com/images/branding/product/ico/maps15_bnuw3a_64dp.ico",
"url": "https://google.com/maps"
},
"hide": [
[
0,
0
],
[
0,
0,
0
],
[
0
],
[
0
]
],
"linksrgapkp": {
"order": 1,
"_id": "linksrgapkp",
"title": "YouTube",
"icon": "https://www.gstatic.com/youtube/img/branding/favicon/favicon_192x192.png",
"url": "https://youtube.com"
},
"quotes": {
"last": 1668708077994,
"author": false,
"type": "inspirobot",
"on": true,
"frequency": "hour"
},
"custom_time": 1650516688,
"lang": "en",
"linksrow": 6,
"background_type": "dynamic",
"reviewPopup": 31,
"showall": true,
"linknewtab": false,
"dynamic": {
"collection": "",
"lastCollec": "night",
"every": "hour",
"time": 1668708077996
},
"weather": {
"fcHigh": 13,
"city": "Paris",
"unit": "metric",
"lastState": {
"sunset": 1668701329,
"feels_like": 10.86,
"temp_max": 12.43,
"temp": 11.56,
"sunrise": 1668668552,
"description": "clear sky",
"icon_id": 800
},
"location": [],
"temperature": "actual",
"forecast": "auto",
"ccode": "FR"
},
"css": "",
"tabtitle": "",
"quicklinks": true,
"textShadow": 0.2,
"custom_every": "pause",
"searchbar": {
"on": false,
"engine": "google",
"newtab": false,
"request": "",
"opacity": 0.1
},
"linksqhipfn": {
"order": 2,
"_id": "linksqhipfn",
"title": "Index.hr",
"icon": "https://www.index.hr/favicon.ico",
"url": "https://index.hr"
},
"background_bright": 0.8,
"clock": {
"analog": false,
"timezone": "auto",
"ampm": false,
"seconds": false,
"face": "none"
},
"linkstyle": "large",
"favicon": "",
"greeting": "Marko",
"linksrbrldh": {
"order": 0,
"_id": "linksrbrldh",
"title": "Facebook",
"icon": "https://static.xx.fbcdn.net/rsrc.php/v3/y8/r/Vuo0AzIJVro.png",
"url": "https://facebook.com"
},
"about": {
"browser": "safari",
"version": "1.15.1"
},
"background_blur": 5,
"notes": {
"on": false,
"align": "left",
"opacity": 0.1,
"text": "### Double click to edit!\n[ ] Supports Markdown and clickable checkboxes \n[ ] With keyboard shortcuts, see documentation"
},
"usdate": false,
"dark": "system",
"font": {
"size": "19.7",
"availWeights": [],
"weight": "300",
"url": "",
"family": ""
}
}

@victrme
Copy link
Owner

victrme commented Nov 18, 2022

Thanks :) I just fixed the issue, actually it was safari not saving properly the changes to storage.

The fix will be live in a few days !

@victrme
Copy link
Owner

victrme commented Nov 19, 2022

Hey, the update is available on Safari right now. Let me know if there's anything else :)

@victrme victrme closed this as completed Nov 19, 2022
@markojurkovic
Copy link
Author

Hey @victrme, thank you for the fix, great stuff! :) Just one side question, pardon the off-topic: do you know of a way to set Bonjourr as homepage in Safari? I know it works for new tabs and windows, but how do you make it run when launching Safari (on macOS at least)?

@victrme
Copy link
Owner

victrme commented Nov 22, 2022

It should work if both those options are enabled:
image

If not, there may be a conflict with another extension ? I'm not really sure.

@markojurkovic
Copy link
Author

markojurkovic commented Nov 22, 2022

No, that works only when you open a second window, that is, a new window after launching Safari initially. But Safari still opens its "Start Page" on initial launch. That is related to the first setting in the screenshot you pasted (Au demarrage...)

EDIT: OK, it works when you set that first setting to "a new window", but when it's set to, for example, "all non-private windows from last session", it doesn't work...

But then you can't get back to the Bonjourr start page if you just want to "go to the homepage" (e.g. if you press the Start Page button, it will take you to Safari's internal Start Page, and if you press the Home button, it will take you to whatever page is set as your homepage.. So no way to get to Bonjourr...

It would be nice to know, for example, if there's a URL that can be used to set Bonjourr as homepage, so that wen you click on the home button, it opens Bonjourr...

@victrme
Copy link
Owner

victrme commented Nov 23, 2022

"all non-private windows from last session" was the only one that I didn't check 😅

It would be nice to know, for example, if there's a URL that can be used to set Bonjourr as homepage, so that wen you click on the home button, it opens Bonjourr...

You can set your URL to https://online.bonjourr.fr. Settings are not synced with your extension though, so you'll have to import them everytime you make changes to the extension.

What I can do for a future update is make it so that clicking on the Bonjourr icon loads the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants