-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple EXT-X-MAP tags #2279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits to address so we can kick off another Netlify build.
Also, add the new initSegment
type to fragment.ts
Hey, it looks like its failing on Testfuncrequired step. Is this happening because I need to add new tests? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@johnBartos @gkolb What's needed to get this PR merged and across the finish line? Happy to take on the work. |
Manually applied changes from video-dev#2279
Manually applied changes from video-dev#2279
Please I found the test stream in #1990: |
@@ -4,7 +4,7 @@ export default class Level { | |||
this.endCC = 0; | |||
this.endSN = 0; | |||
this.fragments = []; | |||
this.initSegment = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned about this being a breaking API change. I don't know who would use hlsjs.levels[n].initSegment
as an integral part of there app, but it's possible.
We could keep this property and just have it reflect the active initSegment used to buffer media (details.initSegments[data.frag.relurl]
).
Hi @gkolb, Can you rebase please? |
@@ -156,6 +157,7 @@ export default class M3U8Parser { | |||
let frag = new Fragment(); | |||
let result; | |||
let i; | |||
let initSegment = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to use the following to resolve a TypeScript error (I branched off v0.14.8):
let initSegment: InitSegment | null = null;
Closing in favor of #3312 due to inactivity. |
This PR will...
Support multiple EXT-X-MAP tags
Why is this Pull Request needed?
HLS doesn't support multiple EXT-X-MAP tags currently
Are there any points in the code the reviewer needs to double check?
Resolves issues:
#1990
Checklist