Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load audio if there is no URI for it in manifest #656

Closed
3 tasks done
FeniXenAaaa opened this issue Aug 29, 2016 · 7 comments
Closed
3 tasks done

Don't load audio if there is no URI for it in manifest #656

FeniXenAaaa opened this issue Aug 29, 2016 · 7 comments
Labels

Comments

@FeniXenAaaa
Copy link

Environment
Steps to reproduce
  1. Use any manifest with audio track defined like that (no URI):
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="aac",NAME="English - Spoken Language",LANGUAGE="EN",AUTOSELECT=YES,DEFAULT=YES
Actual behavior

xhr-loader.js trying to load the resource with empty URL. As a result, the URL equals to current page:

http://currentsite.com/...

This raises the error in loadsuccess function of playlist-loader.js and as a result attempt to recover in HLS what increases the loading time. I think it makes sense to catch such situations and to load resources if the URL is blank.

Console output
trigger @   hls.js:142
loaderror   @   playlist-loader.js:389
loadend @   xhr-loader.js:115
@roquez
Copy link

roquez commented Aug 30, 2016

I encountered the same problem. Here is an example stream url where the issue happens:
http://content.uplynk.com/ext/d874124ecca24c88a3c9575e78686acf/10065013.m3u8

Player is not reacting until all segments are downloaded. Then it starts playing without audio. On Microsoft Edge it doesn't play at all.

Demo page shows the following error:
error while parsing manifest:no EXTM3U delimiter,network error ...

@mangui
Copy link
Member

mangui commented Aug 30, 2016

this should be related to these lines
https://github.com/dailymotion/hls.js/blob/master/src/loader/playlist-loader.js#L367-L369
if you remove them it should work fine.
they were introduced in dailymotion@c965973
to support https://github.com/dailymotion/hls.js/issues/585
basically in case #EXT-X-MEDIA:TYPE=AUDIO is found, with no URL attribute, we should not add a default main audio track

@FeniXenAaaa
Copy link
Author

@mangui Just to clarify, this should be fixed from hls.js side, right?

@mangui
Copy link
Member

mangui commented Aug 31, 2016

Yes

@mangui
Copy link
Member

mangui commented Aug 31, 2016

plz recheck your streams on demo page, issue should be fixed

@FeniXenAaaa
Copy link
Author

@mangui yes, fixed. Thank you very much!

@roquez
Copy link

roquez commented Aug 31, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants