-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't load audio if there is no URI for it in manifest #656
Comments
I encountered the same problem. Here is an example stream url where the issue happens: Player is not reacting until all segments are downloaded. Then it starts playing without audio. On Microsoft Edge it doesn't play at all. Demo page shows the following error: |
this should be related to these lines |
@mangui Just to clarify, this should be fixed from hls.js side, right? |
Yes |
plz recheck your streams on demo page, issue should be fixed |
@mangui yes, fixed. Thank you very much! |
Thanks! |
Environment
Steps to reproduce
Actual behavior
xhr-loader.js trying to load the resource with empty URL. As a result, the URL equals to current page:
This raises the error in loadsuccess function of playlist-loader.js and as a result attempt to recover in HLS what increases the loading time. I think it makes sense to catch such situations and to load resources if the URL is blank.
Console output
The text was updated successfully, but these errors were encountered: