chore: update tests and pages for video.js 7 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OshinKaramian
approved these changes
May 31, 2018
package.json
Outdated
| @@ -65,7 +65,7 @@ | |||
| "mpd-parser": "0.6.1", | |||
| "mux.js": "4.4.1", | |||
| "url-toolkit": "^2.1.3", | |||
| "video.js": "^6.8.0 || ^7.0.0" | |||
| "video.js": "^6.8.0 || ^7.0.3" | |||
There was a problem hiding this comment.
Just need to update this to 7.0.4 (or whatever version the changes in video.core.js are in) when the time comes.
There was a problem hiding this comment.
Well this really indicates what versions of video.js are compatible with VHS, I should actually bump this down to ^7.0.0 and update the lock file to 7.0.4 when that's out
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates all references to the video.js script to video.core.js so that VHS doesn't double up. This isn't totally necessary since VHS should be prepended to the source handler list but it's better to be safe. The package-lock is also updated to install video.js 7.0.3.
This PR requires videojs/video.js#5220
Requirements Checklist