Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: never skip coverage #1108

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

brandonocasey
Copy link
Contributor

Should prevent codecov links from being broken.

@brandonocasey brandonocasey changed the title chore: never skip main coverage chore: never skip coverage Mar 29, 2021
gkatsev
gkatsev previously approved these changes Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1108 (0b32f38) into main (87947fc) will decrease coverage by 0.07%.
The diff coverage is 81.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   86.17%   86.09%   -0.08%     
==========================================
  Files          38       38              
  Lines        8838     8905      +67     
  Branches     1965     1996      +31     
==========================================
+ Hits         7616     7667      +51     
- Misses       1222     1238      +16     
Impacted Files Coverage Δ
src/videojs-http-streaming.js 90.58% <ø> (ø)
src/playlist-loader.js 91.16% <53.84%> (-4.40%) ⬇️
src/manifest.js 97.43% <84.61%> (-2.57%) ⬇️
src/segment-loader.js 95.30% <95.74%> (-0.06%) ⬇️
src/media-segment-request.js 95.73% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33e109...0b32f38. Read the comment docs.

@brandonocasey brandonocasey merged commit b2d2c91 into main Mar 29, 2021
@brandonocasey brandonocasey deleted the chore/never-skip-main-coverage branch March 29, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants