Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/llhls query #1199

Merged
merged 6 commits into from
Sep 15, 2021
Merged

Fix/llhls query #1199

merged 6 commits into from
Sep 15, 2021

Conversation

brandonocasey
Copy link
Contributor

Description

Fixes #1198

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #1199 (b3e6c5c) into main (8160019) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b3e6c5c differs from pull request most recent head 09bf6c6. Consider uploading reports for the commit 09bf6c6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
+ Coverage   86.59%   86.61%   +0.01%     
==========================================
  Files          39       39              
  Lines        9645     9651       +6     
  Branches     2233     2235       +2     
==========================================
+ Hits         8352     8359       +7     
+ Misses       1293     1292       -1     
Impacted Files Coverage Δ
src/playlist-loader.js 94.70% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517386...09bf6c6. Read the comment docs.

loader.on('trackinfo', () => {
loader.on('playlistupdate', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the race condition that currently causes ie 11 to fail


uri += `${symbol}${str}`;
});
['_HLS_skip', '_HLS_msn', '_HLS_part'].forEach(function(name) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make sure that we keep the parameters in an expected order of skip, msn, and part as it makes reading the urls much easier.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested it and it works.

@brandonocasey brandonocasey merged commit a8d3c1a into main Sep 15, 2021
@brandonocasey brandonocasey deleted the fix/llhls-query branch September 15, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLHLS - playlist loader, querystring breaks uri
2 participants