feat: add frameRate property to the representation class. #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1289 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 39 39
Lines 9855 9856 +1
Branches 2298 2298
=======================================
+ Hits 8506 8507 +1
Misses 1349 1349
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5 tasks
gkatsev
approved these changes
Jul 28, 2022
|
I guess this needs to wait for the m3u8-parser and mpd-parser updates. |
|
Yes, that's correct. |
7 tasks
|
Just published m3u8-parser 4.8.0 with this as well as videojs-contrib-quality-levels 2.2.0. |
|
and mpd-parser 0.22.0 is out too. |
|
Thank you. I guess we are one step closer to merging this PR. |
|
@gjanblaszczyk if you can update this PR with the new (non-major) versions, we can merge this in and release it. |
gkatsev
approved these changes
Sep 14, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
gkatsev
pushed a commit
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to display to the user the frame rate value for the currently playing quality level. However, it is not possible because the Representation class doesn't have the frameRate property.
This PR is related to this videojs/mpd-parser#159
Specific Changes proposed
Add frameRate property to the Representation class.
Requirements Checklist