feat: Remove remnants of IE and old Edge #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
commented
Oct 27, 2022
| // in IE and Edge, but seeking in place is sufficient on all other browsers) | ||
| // Edge/IE bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/14600375/ | ||
| // Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=651904 | ||
| this.mainSegmentLoader_.resetEverything(() => { | ||
| // Since this is not a typical seek, we avoid the seekTo method which can cause segments | ||
| // from the previously enabled rendition to load before the new playlist has finished loading | ||
| if (videojs.browser.IE_VERSION || videojs.browser.IS_EDGE) { |
There was a problem hiding this comment.
I think this was only needed for legacy Edge
mister-ben
commented
Oct 27, 2022
| @@ -576,7 +576,7 @@ export default class SegmentLoader extends videojs.EventTarget { | |||
| // TODO possibly move gopBuffer and timeMapping info to a separate controller | |||
| this.gopBuffer_ = []; | |||
| this.timeMapping_ = 0; | |||
| this.safeAppend_ = videojs.browser.IE_VERSION >= 11; | |||
| this.safeAppend_ = false; | |||
There was a problem hiding this comment.
Possibly safeAppend_ could be removed completely if it was only used with IE11
Codecov Report
@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
- Coverage 85.38% 85.36% -0.02%
==========================================
Files 40 40
Lines 9966 9957 -9
Branches 2314 2311 -3
==========================================
- Hits 8509 8500 -9
Misses 1457 1457
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7 tasks
gkatsev
approved these changes
Oct 29, 2022
|
Would be good if either @brandonocasey or @gesinger would have a change to take a look at this. |
|
Just noting here that we'll merge this post-3.0 because 3.0 will be broken in IE and legacy Edge regardless. |
misteroneill
approved these changes
Feb 23, 2023
gkatsev
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes most remaining IE specific code, in part to be able to remove
videojs.browser.IE_VERSION.Also removes some legacy Edge checks.
Requirements Checklist