Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Public function for updating VHS options #1446

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

wseymour15
Copy link
Contributor

@wseymour15 wseymour15 commented Nov 16, 2023

Description

Public function for updating VHS options. This gives the user a way top update VHS config after initialization of the player.

Specific Changes proposed

  • Create setOptions function

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 151 lines in your changes are missing coverage. Please review.

Comparison is base (532aa4d) 85.98% compared to head (92a3003) 12.96%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/playlist-loader.js 0.00% 101 Missing ⚠️
src/playlist-controller.js 0.00% 43 Missing ⚠️
src/content-steering-controller.js 30.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1446       +/-   ##
===========================================
- Coverage   85.98%   12.96%   -73.02%     
===========================================
  Files          42       42               
  Lines       10458    10613      +155     
  Branches     2419     2445       +26     
===========================================
- Hits         8992     1376     -7616     
- Misses       1466     9237     +7771     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wseymour15 wseymour15 self-assigned this Nov 17, 2023
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wseymour15 wseymour15 merged commit 9f2a4de into main Nov 21, 2023
10 of 14 checks passed
@wseymour15 wseymour15 deleted the feat/function-to-update-vhs-config branch November 21, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants