chore: Switch to our quality selector #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 43 43
Lines 11097 11097
Branches 2532 2532
=======================================
Hits 9578 9578
Misses 1519 1519 ☔ View full report in Codecov by Sentry. |
gkatsev
requested changes
Jul 17, 2024
There was a problem hiding this comment.
https://github.com/videojs/http-streaming/blob/main/scripts/netlify.js#L13-L15 needs updates as well to include the new css an js files
mister-ben
force-pushed
the
chore-quality-selector
branch
from
acc432a to
62dda03
Compare
gkatsev
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use videojs/videojs-contrib-quality-menu in the demo page
Requirements Checklist