fix: allow vtt rollover with MPEGTS of 0 #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
- Coverage 86.36% 86.36% -0.01%
==========================================
Files 43 43
Lines 11151 11149 -2
Branches 2548 2546 -2
==========================================
- Hits 9631 9629 -2
Misses 1520 1520 ☔ View full report in Codecov by Sentry. |
dzianis-dashkevich
approved these changes
Aug 30, 2024
9 tasks
adrums86
added a commit
to videojs/video.js
that referenced
this pull request
Sep 10, 2024
## Description Update VHS to v3.14.1 for a VTT timing fix detailed here: videojs/http-streaming#1537 ## Specific Changes proposed Update the VHS package to v.3.14.1. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [ ] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors --------- Co-authored-by: Essk <sarah@teaandbiscuits.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
handleRolloverto be called on vtt segments when theMPEGTSvalue from theX-TIMESTAMP-MAPtag is 0Specific Changes proposed
Remove the
MPEGTS === 0check and associated ternary.Requirements Checklist