fix: playlists wrongfully excluded on iOS when using ManagedMediaSource #1555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
browserSupportsCodec()
vhs-utils method was recently updated to support cases whereManagedMediaSource
is supported and in use. This is accomplished by passing a 2nd argumentwithMMS
that defaults tofalse
. Invocations ofbrowserSupportsCodec()
in VHS weren't passing this 2nd arg, resulting in cases on iOS (whereMediaSource
isn't supported) where VHS thought errantly that supported codecs were not supported, resulting in playlists being wrongly excluded.Specific Changes proposed
ManagedMediaSource
is being usedbrowserSupportsCodec()
callsRequirements Checklist