Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playlists wrongfully excluded on iOS when using ManagedMediaSource #1555

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

alex-barstow
Copy link
Contributor

@alex-barstow alex-barstow commented Nov 27, 2024

Description

The browserSupportsCodec() vhs-utils method was recently updated to support cases where ManagedMediaSource is supported and in use. This is accomplished by passing a 2nd argument withMMS that defaults to false. Invocations of browserSupportsCodec() in VHS weren't passing this 2nd arg, resulting in cases on iOS (where MediaSource isn't supported) where VHS thought errantly that supported codecs were not supported, resulting in playlists being wrongly excluded.

Specific Changes proposed

  • Add flag in PlaylistController indicating whether a ManagedMediaSource is being used
  • Pass that value to browserSupportsCodec() calls

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (390cdfd) to head (c47941b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files          44       44           
  Lines       11681    11683    +2     
  Branches     2612     2612           
=======================================
+ Hits         9807     9809    +2     
  Misses       1874     1874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-barstow alex-barstow merged commit 3c4bbf1 into main Nov 27, 2024
15 checks passed
@alex-barstow alex-barstow deleted the fix/mms-on-ios branch November 27, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants