Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify setupEmeOptions and add tests #869

Merged
merged 2 commits into from
Jul 6, 2020
Merged

refactor: simplify setupEmeOptions and add tests #869

merged 2 commits into from
Jul 6, 2020

Conversation

gesinger
Copy link
Contributor

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gesinger gesinger mentioned this pull request Jun 19, 2020
Merged
6 tasks
brandonocasey
brandonocasey previously approved these changes Jun 19, 2020
View reviewed changes
@gkatsev gkatsev changed the base branch from master to main June 19, 2020 16:50
@gkatsev gkatsev dismissed brandonocasey’s stale review June 19, 2020 16:50

The base branch was changed.

@gkatsev gkatsev changed the title chore: simplify setupEmeOptions and add tests refactor: simplify setupEmeOptions and add tests Jun 19, 2020
@gkatsev gkatsev added this to the 2.1 milestone Jul 6, 2020
@gkatsev gkatsev merged commit e3921ed into videojs:main Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@brandonocasey brandonocasey brandonocasey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gesinger @gkatsev @brandonocasey