chore: update release ci and add github-release #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Aug 24, 2021
Comment on lines
-47
to
-57
| - run: npm i --prefer-offline --no-audit | ||
| node-version: '${{steps.nvm.outputs.NVMRC}}' | ||
| cache: npm | ||
|
|
||
| # run safari on macos | ||
| - name: Run Mac test | ||
| run: npm run test -- --browsers Safari | ||
| if: ${{ startsWith(matrix.os, 'macos') }} | ||
| # turn off the default setup-node problem watchers... | ||
| - run: echo "::remove-matcher owner=eslint-compact::" | ||
| - run: echo "::remove-matcher owner=eslint-stylish::" | ||
| - run: echo "::remove-matcher owner=tsc::" | ||
|
|
||
| # only run ie 11 on windows | ||
| - name: Run Windows test | ||
| run: npm run test -- --browsers IE | ||
| if: ${{ startsWith(matrix.os, 'windows') }} |
There was a problem hiding this comment.
it seems like this is something we want to keep?
There was a problem hiding this comment.
We don't want the os --browsers thing no. Old version of the ci script operated under the assumption that we would forgo browserstack at some point. Eventually we decided that we can make that jump later and removed all the code for os specific browser runs.
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage ? 92.84%
=======================================
Files ? 17
Lines ? 657
Branches ? 212
=======================================
Hits ? 610
Misses ? 47
Partials ? 0 Continue to review full report at Codecov.
|
gkatsev
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.