Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use manifest uri in base urls #176

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

wseymour15
Copy link
Contributor

Fix for a bug introduced in v1.2.0. This ensures that we correctly use the manifestUri when necessary in resolvedUris in segments from the mpd parser.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #176 (e824a08) into main (c40dc0d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          19       19           
  Lines         824      824           
  Branches      251      251           
=======================================
  Hits          780      780           
  Misses         44       44           
Files Changed Coverage Δ
src/inheritAttributes.js 97.70% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. 🍻

@wseymour15 wseymour15 merged commit 5faf232 into main Aug 16, 2023
8 checks passed
@wseymour15 wseymour15 deleted the fix/use-manifest-uri-in-base-urls branch August 16, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants