fix: improve serviceLocation for content steering #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 94.66% 94.68% +0.02%
==========================================
Files 19 19
Lines 824 846 +22
Branches 251 258 +7
==========================================
+ Hits 780 801 +21
- Misses 44 45 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wseymour15
changed the title
adrums86
previously approved these changes
Aug 22, 2023
adrums86
dismissed
their stale review
Removing approval temporarily while we ensure discontinuities are consistent.
adrums86
approved these changes
Aug 29, 2023
wseymour15
deleted the
fix/improve-service-location-for-content-steering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to ensure the
serviceLocationfield from the BaseURLs from DASH manifests are passed to VHS correctly.