fix: don't adjust mediaPresentationDuration by timescale for segment … #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duration when using SegmentBase When using SegmentBase, there is only one segment. If the duration is not present, sourceDuration is used, which comes from mediaPresentationDuration. Previously, sourceDuration was being divided by the timescale, but mediaPresentationDuration is defined in the DASH spec as s:duration, which follows ISO 8601. It doesn't need to be adjusted based on the timescale. This change fixes the use of sourceDuration for SegmentBase by not performing that division.
gkatsev
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…duration when using SegmentBase
When using SegmentBase, there is only one segment. If the duration is
not present, sourceDuration is used, which comes from
mediaPresentationDuration.
Previously, sourceDuration was being divided by the timescale, but
mediaPresentationDuration is defined in the DASH spec as s:duration,
which follows ISO 8601. It doesn't need to be adjusted based on the
timescale.
This change fixes the use of sourceDuration for SegmentBase by not
performing that division.