refactor: rename warn event to log, change console logs to log events #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jul 8, 2021
lib/mp4/caption-parser.js
Outdated
| @@ -452,4 +460,6 @@ var CaptionParser = function() { | |||
| this.reset(); | |||
| }; | |||
|
|
|||
| CaptionParser.prototype = new Stream(); | |||
There was a problem hiding this comment.
Had to make this a stream as we don't have a better way to get listeners right now.
brandonocasey
commented
Jul 8, 2021
| @@ -10,6 +10,8 @@ var dashInit = segments['dash-608-captions-init.mp4'](); | |||
| // This file includes 2 segments data to force a flush | |||
| // of the first caption. The second caption is at 200s | |||
| var dashSegment = segments['dash-608-captions-seg.m4s'](); | |||
| var malformedSei = segments['malformed-sei.m4s'](); | |||
| var malformedSeiInit = segments['malformed-sei-init.mp4'](); | |||
There was a problem hiding this comment.
Added these from the old issue, we should have done it then 🤷🏻
brandonocasey
commented
Jul 8, 2021
lib/mp4/caption-parser.js
Outdated
| @@ -97,8 +98,7 @@ var findSeiNals = function(avcStream, samples, trackId) { | |||
| seiNal.pts = lastMatchedSample.pts; | |||
| seiNal.dts = lastMatchedSample.dts; | |||
| } else { | |||
| // eslint-disable-next-line no-console | |||
| console.log("We've encountered a nal unit without data. See mux.js#233."); | |||
| logWarn("We've encountered a nal unit without data. See mux.js#223."); | |||
There was a problem hiding this comment.
The issue number was wrong here. It was actually 223 not 233
gkatsev
approved these changes
Jul 9, 2021
brandonocasey
commented
Jul 9, 2021
| @@ -91,8 +91,6 @@ var | |||
| MetadataStream = function(options) { | |||
| var | |||
| settings = { | |||
| debug: !!(options && options.debug), | |||
There was a problem hiding this comment.
debug was only used for this console.log, now we just trigger an event at any time and the user can choose what to do.
gkatsev
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.