Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent adding duplicate log listeners #402

Merged
merged 3 commits into from
Oct 14, 2021
Merged

fix: prevent adding duplicate log listeners #402

merged 3 commits into from
Oct 14, 2021

Conversation

brandonocasey
Copy link
Contributor

Since we re-use the pipeline when we flush and push the same content, duplicate log listeners are being added.

gkatsev
gkatsev reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, now we only add the log listener when we pipeline is created instead of every push?

@brandonocasey
Copy link
Contributor Author

brandonocasey commented Oct 14, 2021 •
edited
Loading

Yeah exactly. Every push after a flush.

@brandonocasey brandonocasey merged commit eb332c1 into main Oct 14, 2021
@brandonocasey brandonocasey deleted the fix/prevent-duplicate-logs branch October 14, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev