fix: properly handle data URIs #27

gkatsev · 2021-05-20T17:44:31Z

There are the following two cases:

a data URI is provided for the baseURL
- in this case, ignore the data URI and resolve against window.location or a default location
a data URI is provided for the relativeURL
- in this case, return the data URI as it should be treated as an absolute URL

brandonocasey · 2021-05-20T18:22:45Z

src/resolve-url.js

@@ -9,6 +9,11 @@ const resolveUrl = (baseUrl, relativeUrl) => {
 return relativeUrl;
 }

+ // if baseUrl is a data URI, ignore it and resolve everything relative to window.location
+ if ((/^data:/).test(baseUrl)) {
+ baseUrl = window.location && window.location.href;


should we add an || '' to the end here so that baseUrl isn't undefined in node?

gkatsev added 5 commits May 20, 2021 13:37

add a failing test for resolve url with a data uri

4737bc2

data uri as relative url is not resolved relatively but returned

49f9720

set baseURL to window.location when data URIs are used

533ba4d

window.location.href for IE11

2a24258

and of course do a null check

f0da568

brandonocasey reviewed May 20, 2021

View reviewed changes

add a default

3ceaf8c

brandonocasey approved these changes May 20, 2021

View reviewed changes

gkatsev merged commit 9b10245 into main May 20, 2021

gkatsev deleted the data-uris branch May 20, 2021 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: properly handle data URIs #27

fix: properly handle data URIs #27

gkatsev commented May 20, 2021 •

edited

Loading

brandonocasey May 20, 2021

fix: properly handle data URIs #27

fix: properly handle data URIs #27

Conversation

gkatsev commented May 20, 2021 • edited Loading

brandonocasey May 20, 2021

Choose a reason for hiding this comment

gkatsev commented May 20, 2021 •

edited

Loading