fix: look at all program map tables for ts stream types #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Jun 17, 2021
| @@ -1,6 +1,9 @@ | |||
| import {bytesMatch, toUint8} from './byte-helpers.js'; | |||
| const SYNC_BYTE = 0x47; | |||
|
|
|||
| // use of maxPes is deprecated as we should always look at | |||
There was a problem hiding this comment.
we should make sure to add this to the commit message when we merge
brandonocasey
added a commit
that referenced
this pull request
Jul 15, 2021
use of maxPes in `m2ts-helpers#parseTs` is deprecated. We should always look at all pes packets to prevent being caught off guard by changes in that stream that happen after the pes specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to look at all program map tables in a ts file to determine what streams it contains. If we don't we may run into the scenario where streams are added that we don't account for.