Add media-types module with simpleTypeFromSourceType function #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Nov 21, 2019
gkatsev
reviewed
Nov 21, 2019
gkatsev
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that with this PR, the scope of this module changes to encompass more use-cases. See the README notes for details.
Also note that this includes functionality for videojs/http-streaming#649, and helps to break that PR up into fewer code changes per PR. If this gets merged, those functions can be stripped from @videojs/http-streaming and simply reference this module's functions.
So long as the scope change of this module is acceptable, more PRs will be added soon with additional extracted functions from VHS.
Code derived from https://github.com/videojs/http-streaming/blob/master/src/videojs-http-streaming.js#L85