fix(skip-forward): error when clicking after player reset (#8258)

videojs · May 31, 2023 · 07effdf · 07effdf
1 parent e73e05d
commit 07effdf
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/js/control-bar/skip-buttons/skip-forward.js b/src/js/control-bar/skip-buttons/skip-forward.js
@@ -46,6 +46,10 @@ class SkipForward extends Button {
    *        to be called
    */
   handleClick(event) {
+    if (isNaN(this.player_.duration())) {
+      return;
+    }
+
     const currentVideoTime = this.player_.currentTime();
     const liveTracker = this.player_.liveTracker;
     const duration = (liveTracker && liveTracker.isLive()) ? liveTracker.seekableEnd() : this.player_.duration();

diff --git a/test/unit/control-bar/skip-buttons/skip-forward-button.test.js b/test/unit/control-bar/skip-buttons/skip-forward-button.test.js
@@ -128,3 +128,21 @@ QUnit.test('localizes on languagechange', function(assert) {
 
   player.dispose();
 });
+
+QUnit.test('skips forward only if the duration is valid', function(assert) {
+  const player = TestHelpers.makePlayer({controlBar: {skipButtons: {forward: 5}}});
+  const currentTimeSpy = sinon.spy(player, 'currentTime');
+  const button = player.controlBar.skipForward;
+
+  button.trigger('click');
+
+  assert.ok(currentTimeSpy.notCalled, 'currentTime was not called');
+
+  player.duration(0);
+  button.trigger('click');
+
+  assert.ok(currentTimeSpy.called, 'currentTime was called');
+
+  currentTimeSpy.restore();
+  player.dispose();
+});