fix: Set alt attr on poster img (#8043)

* fix: Set alt attr on poster img * use null alt instead * remove debug text
videojs · Jan 24, 2023 · 3accbc7 · 3accbc7
1 parent e21d295
commit 3accbc7
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/src/js/poster-image.js b/src/js/poster-image.js
@@ -46,15 +46,21 @@ class PosterImage extends ClickableComponent {
    *         The element that gets created.
    */
   createEl() {
-    const el = Dom.createEl('picture', {
-      className: 'vjs-poster',
-
-      // Don't want poster to be tabbable.
-      tabIndex: -1
-    }, {}, Dom.createEl('img', {
-      loading: 'lazy',
-      crossOrigin: this.crossOrigin()
-    }));
+    const el = Dom.createEl(
+      'picture', {
+        className: 'vjs-poster',
+
+        // Don't want poster to be tabbable.
+        tabIndex: -1
+      },
+      {},
+      Dom.createEl('img', {
+        loading: 'lazy',
+        crossOrigin: this.crossOrigin()
+      }, {
+        alt: ''
+      })
+    );
 
     return el;
   }

diff --git a/test/unit/poster.test.js b/test/unit/poster.test.js
@@ -42,6 +42,12 @@ QUnit.test('should mirror crossOrigin', function(assert) {
 
 });
 
+QUnit.test('should populate an alt attribute', function(assert) {
+  const posterImage = new PosterImage(this.mockPlayer);
+
+  assert.ok(posterImage.$('img').hasAttribute('alt'), 'img has alt atttribute');
+});
+
 QUnit.test('should remove itself from the document flow when there is no poster', function(assert) {
   const posterImage = new PosterImage(this.mockPlayer);