Skip to content

Commit 5e6b536

Browse files
mister-benadrums86
andauthored
feat: add class to normalise time control display (#8833)
## Description Time controls continue to cause confusion as they are included by default but hidden by default. e.g. #8534 Adding CSS to display them is not intuitive. ## Specific Changes proposed Changing the default styles would be problematic before a major version. This PR proposes adding an optional `vjs-normalise-time-controls` class a user can add to the player, as an opt in. This will default all time controls to being shown, except when live content is playing. Users would then have to remove the time controls in player options, or with `hide()` or `dispose()`. ## Requirements Checklist - [ ] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors Co-authored-by: Adam Waldron <acwald@gmail.com>
1 parent 8c56e31 commit 5e6b536

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/css/components/_time.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@
1919
display: none;
2020
line-height: 3em;
2121
}
22+
23+
.vjs-normalise-time-controls:not(.vjs-live) .vjs-time-control {
24+
display: flex;
25+
}

0 commit comments

Comments
 (0)