Skip to content

Commit 86d29cd

Browse files
authored
fix: Listen to taps on track controls (#8809)
## Description The refactored text track controls aren't listening for tap events. ## Specific Changes proposed Add tap handler to done and reset buttons. Fixes #8808 ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
1 parent a7c9f26 commit 86d29cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/js/tracks/text-track-settings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,12 +332,12 @@ class TextTrackSettings extends ModalDialog {
332332
}
333333

334334
bindFunctionsToSelectsAndButtons() {
335-
this.on(this.$('.vjs-done-button'), 'click', () => {
335+
this.on(this.$('.vjs-done-button'), ['click', 'tap'], () => {
336336
this.saveSettings();
337337
this.close();
338338
});
339339

340-
this.on(this.$('.vjs-default-button'), 'click', () => {
340+
this.on(this.$('.vjs-default-button'), ['click', 'tap'], () => {
341341
this.setDefaults();
342342
this.updateDisplay();
343343
});

0 commit comments

Comments
 (0)